Skip to content

Commit

Permalink
1124 viewers are not allowed in rotations (#1577)
Browse files Browse the repository at this point in the history
# What this PR does
Added additional filtering for roles 0 and 1 for rodations. Only Editors
and Admins are allowed to be in rotation

## Which issue(s) this PR fixes
#1124
  • Loading branch information
Ukochka authored Mar 20, 2023
1 parent ad8ec64 commit 046d1dc
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

- Updated wording throughout plugin to use 'Alert Group' instead of 'Incident' ([1565](https://github.com/grafana/oncall/pull/1565),
[1576](https://github.com/grafana/oncall/pull/1576))
- Filtering for Editors/Admins was added to rotation form. It is not allowed to assign Viewer to rotation ([1124](https://github.com/grafana/oncall/issues/1124))

### Fixed

Expand Down
2 changes: 1 addition & 1 deletion grafana-plugin/src/components/UserGroups/UserGroups.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ const UserGroups = (props: UserGroupsProps) => {
key={items.length}
showSearch
placeholder="Add user"
href="/users/?filters=true"
href="/users/?roles=0&roles=1&filters=true"
value={null}
onChange={handleUserAdd}
showError={showError}
Expand Down

0 comments on commit 046d1dc

Please sign in to comment.