Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Viewers are not allowed in a rotation #1124

Closed
matiasb opened this issue Jan 11, 2023 · 0 comments
Closed

Viewers are not allowed in a rotation #1124

matiasb opened this issue Jan 11, 2023 · 0 comments
Assignees
@Ukochka
Labels
bug Something isn't working involved:Frontend part:schedules

Comments

@matiasb
Copy link
Contributor

matiasb commented Jan 11, 2023

Right now you can choose any user when creating a rotation using the web schedule UI, without any warning if the user has a viewer role, which will leave the shift empty.

Users with a viewer role shouldn't be available for selection when creating a rotation (also, if a user part of a rotation is downgraded to Viewer later, the schedule should warn about the now empty shift), or they should be able to be on-call. See related issue #524.
@matiasb matiasb added the bug Something isn't working label Jan 11, 2023
@Ukochka Ukochka mentioned this issue Mar 20, 2023
Merged
brojd pushed a commit that referenced this issue Sep 18, 2024
@Ukochka
1124 viewers are not allowed in rotations (#1577)
d6b8914 
# What this PR does
Added additional filtering for roles 0 and 1 for rodations. Only Editors
and Admins are allowed to be in rotation

## Which issue(s) this PR fixes
#1124
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ukochka Ukochka

Labels
bug Something isn't working involved:Frontend part:schedules
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@matiasb @maskin25 @Matvey-Kuk @Ukochka