Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Users page not filtering all the times properly #2842

Closed
teodosii opened this issue Aug 21, 2023 · 0 comments
Closed

Users page not filtering all the times properly #2842

teodosii opened this issue Aug 21, 2023 · 0 comments
Assignees
@teodosii
Labels
bug Something isn't working involved:Frontend

Comments

@teodosii
Copy link
Member

teodosii commented Aug 21, 2023 •
edited
Loading

What went wrong?

What happened:

  • Go to Users page and the very first thing to do is to input a name in the search box - it leads to few refreshes and sometimes you see your searched user, sometimes you see whole users list

What did you expect to happen:

  • Once I search a user I expect to see a list of users that match with that search

How do we reproduce it?

  1. Go to users page
  2. Type in a user
  3. Wait for search to happens - it will either filter or not, doing a few list refresh in the meanwhile

Grafana OnCall Version

all

Product Area

Other

Grafana OnCall Platform?

None

User's Browser?

No response

Anything else to add?

No response

This behavior can be easily observed on oncalldev or ops where there's slight latency
@teodosii teodosii added bug Something isn't working involved:Frontend labels Aug 21, 2023
@teodosii teodosii self-assigned this Aug 21, 2023
@teodosii teodosii mentioned this issue Aug 21, 2023
Merged
3 tasks
github-merge-queue bot pushed a commit that referenced this issue Aug 22, 2023
@teodosii
Users search fix (#2847)
b8a04b6 
# Changes

- Prevent duplicated call to /users on search
- Fix the issue described at #2842 where there was a concurrency issue
between the page load request and the search request

## Which issue(s) this PR fixes

Fix for #2842

## Checklist

- [ ] Unit, integration, and e2e (if applicable) tests updated
- [ ] Documentation added (or `pr:no public docs` PR label added if not
required)
- [ ] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not
required)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@teodosii teodosii

Labels
bug Something isn't working involved:Frontend
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@teodosii