Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users search fix #2847

Merged
merged 7 commits into from
Aug 22, 2023
Merged

Users search fix #2847

merged 7 commits into from
Aug 22, 2023

Conversation

teodosii
Copy link
Member

@teodosii teodosii commented Aug 21, 2023

Changes

Which issue(s) this PR fixes

Fix for #2842

Checklist

  • Unit, integration, and e2e (if applicable) tests updated
  • Documentation added (or pr:no public docs PR label added if not required)
  • CHANGELOG.md updated (or pr:no changelog PR label added if not required)

@teodosii teodosii requested a review from a team August 21, 2023 15:18
@teodosii teodosii added the pr:no public docs Added to a PR that does not require public documentation updates label Aug 21, 2023
Copy link
Contributor

@joeyorlando joeyorlando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you mind adding some form of testing, whether it be unit and/or e2e?

@teodosii
Copy link
Member Author

@joeyorlando sure, will add an e2e test

@teodosii
Copy link
Member Author

@joeyorlando added the e2e test

@teodosii teodosii added this pull request to the merge queue Aug 22, 2023
Merged via the queue into dev with commit b8a04b6 Aug 22, 2023
@teodosii teodosii deleted the rares/2842 branch August 22, 2023 13:35
brojd pushed a commit that referenced this pull request Sep 18, 2024
# Changes

- Prevent duplicated call to /users on search
- Fix the issue described at #2842 where there was a concurrency issue
between the page load request and the search request

## Which issue(s) this PR fixes

Fix for #2842

## Checklist

- [ ] Unit, integration, and e2e (if applicable) tests updated
- [ ] Documentation added (or `pr:no public docs` PR label added if not
required)
- [ ] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not
required)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:no public docs Added to a PR that does not require public documentation updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants