Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow editing assigned team via public api #1619

Merged
merged 8 commits into from
Apr 5, 2023
Merged

Allow editing assigned team via public api #1619

merged 8 commits into from
Apr 5, 2023

Conversation

iskhakov
Copy link
Contributor

@iskhakov iskhakov commented Mar 27, 2023 •
edited
Loading

What this PR does

For example, changing the integration's team

curl "localhost:8080/api/v1/integrations/CLYV3QBVHDV3T/" \
  --request PUT \
  --header "Authorization: meow" \
  --header "Content-Type: application/json" --data '{"team_id": "TWP6JJJN6LYZX"}'

Which issue(s) this PR fixes

Checklist

  • Unit, integration, and e2e (if applicable) tests updated
  • Documentation added (or pr:no public docs PR label added if not required)
  • CHANGELOG.md updated (or pr:no changelog PR label added if not required)

@iskhakov iskhakov requested a review from a team March 27, 2023 02:01
@iskhakov iskhakov added the pr:no public docs Added to a PR that does not require public documentation updates label Mar 27, 2023
@Konstantinov-Innokentii
Copy link
Member

Konstantinov-Innokentii commented Mar 27, 2023 •
edited
Loading

LGTM, left some comments.
At that moment, terraform (as well as api-client) doesn't support team_id parameter for updating resources

It will be great to add api tests for changing team for resources which supports it.

@iskhakov
Copy link
Contributor Author

Changed api client and terraform plugin
grafana/terraform-provider-grafana#864
grafana/amixr-api-go-client#11

@Konstantinov-Innokentii Konstantinov-Innokentii added this pull request to the merge queue Apr 5, 2023
Merged via the queue into dev with commit 498e7ed Apr 5, 2023
@Konstantinov-Innokentii Konstantinov-Innokentii deleted the iskhakov/public-api-teams-editable branch April 5, 2023 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Konstantinov-Innokentii Konstantinov-Innokentii Konstantinov-Innokentii approved these changes

Assignees
No one assigned
Labels
pr:no public docs Added to a PR that does not require public documentation updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iskhakov @Konstantinov-Innokentii