Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow editing team for OnCall resources #864

Merged
merged 7 commits into from
Jun 26, 2023
Merged

Allow editing team for OnCall resources #864

merged 7 commits into from
Jun 26, 2023

Conversation

iskhakov
Copy link
Contributor

No description provided.

@iskhakov iskhakov requested a review from a team as a code owner March 28, 2023 07:52
@github-actions
Copy link

In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically. To do so, a Grafana Labs employee must promote the Drone build.

For maintainers, it's better to run only the Cloud tests you need, rather than all of them. You can do so by setting the following parameter when promoting:

TESTARGS='-run=<testname>'

@iskhakov iskhakov mentioned this pull request Mar 28, 2023
Merged
3 tasks
inkel
inkel requested changes Mar 28, 2023
View reviewed changes
Copy link
Contributor

@inkel inkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've found a typo which should be corrected. While at it, while not naming the variable teamID instead? I know there are others that have a Data suffix and I don't like those either, but changing them is out of the scope of this PR 😬

internal/resources/oncall/resource_integration.go Outdated Show resolved Hide resolved
@julienduchesne julienduchesne force-pushed the iskhakov/allow-edit-team branch from 2785625 to fee80b0 Compare June 2, 2023 17:28
@julienduchesne julienduchesne force-pushed the iskhakov/allow-edit-team branch from fee80b0 to 80600cb Compare June 5, 2023 19:43
@julienduchesne julienduchesne linked an issue Jun 5, 2023 that may be closed by this pull request
Update team id at oncall resources are not effective #854
Closed
@julienduchesne
Copy link
Member

Hey @iskhakov. Any progress on this? I see it's missing grafana/amixr-api-go-client#11

@iskhakov iskhakov self-assigned this Jun 22, 2023
@iskhakov iskhakov merged commit 202828b into master Jun 26, 2023
@iskhakov iskhakov deleted the iskhakov/allow-edit-team branch June 26, 2023 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inkel inkel inkel approved these changes

@Konstantinov-Innokentii Konstantinov-Innokentii Awaiting requested review from Konstantinov-Innokentii

Assignees

@iskhakov iskhakov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update team id at oncall resources are not effective
4 participants
@iskhakov @julienduchesne @inkel @Konstantinov-Innokentii