Allow more escalation step wait times over public api #5201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mderynck
added
pr:no public docs
mderynck
had a problem deploying
to
github-pages
GitHub Actions
Failure
mderynck
removed
the
pr:no public docs
mderynck
had a problem deploying
to
github-pages
GitHub Actions
Failure
mderynck
had a problem deploying
to
github-pages
GitHub Actions
Failure
matiasb
reviewed
Oct 23, 2024
| | `position` | Optional | Escalation policies execute one after another starting from `position=0`. `Position=-1` will put the escalation policy to the end of the list. A new escalation policy created with a position of an existing escalation policy will move the old one (and all following) down in the list. | | ||
| | `type` | Yes | One of: `wait`, `notify_persons`, `notify_person_next_each_time`, `notify_on_call_from_schedule`, `notify_user_group`, `trigger_webhook`, `resolve`, `notify_whole_channel`, `notify_if_time_from_to`, `declare_incident`. | | ||
| | `important` | Optional | Default is `false`. Will assign "important" to personal notification rules if `true`. This can be used to distinguish alerts on which you want to be notified immediately by phone. Applicable for types `notify_persons`, `notify_team_members`, `notify_on_call_from_schedule`, and `notify_user_group`. | | ||
| | `duration` | If type = `wait` | The duration, in seconds, when type `wait` is chosen. Valid values are: `60-86400`. | |
There was a problem hiding this comment.
Maybe is not that clear enough that any value in the range is valid?
| @@ -143,18 +151,10 @@ def to_representation(self, instance): | |||
| result = super().to_representation(instance) | |||
| result = self._get_field_to_represent(step, result) | |||
| if "duration" in result and result["duration"] is not None: | |||
| result["duration"] = result["duration"].seconds | |||
| result["duration"] = int(float(result["duration"])) | |||
There was a problem hiding this comment.
Is this conversion needed? (from what I see in the field definition, the to_representation should return the right repr?)
There was a problem hiding this comment.
Without this the DurationSecondsField returns a float as a string:
{
"position": 0,
"id": "E6J46FYHBXGUW",
"escalation_chain_id": "FDWP4BEVEZD9C",
"type": "wait",
"duration": "111.0"
},
There was a problem hiding this comment.
Probably don't really need to use that DurationSecondsField but I used it to match the other internal API serializer.
There was a problem hiding this comment.
hm.. right. Sounds ok then 👍
mderynck
had a problem deploying
to
github-pages
GitHub Actions
Failure
matiasb
approved these changes
Oct 23, 2024
| @@ -143,18 +151,10 @@ def to_representation(self, instance): | |||
| result = super().to_representation(instance) | |||
| result = self._get_field_to_represent(step, result) | |||
| if "duration" in result and result["duration"] is not None: | |||
| result["duration"] = result["duration"].seconds | |||
| result["duration"] = int(float(result["duration"])) | |||
There was a problem hiding this comment.
hm.. right. Sounds ok then 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Remove restriction on wait times when changing escalation step wait times. 60-86400 seconds values are accepted.
grafana/terraform-provider-grafana#1855 removes the restriction in the terraform provider.
Which issue(s) this PR closes
Related to: https://github.com/grafana/support-escalations/issues/13065
Checklist
pr:no public docsPR label added if not required)release:). These labels dictate how your PR willshow up in the autogenerated release notes.