Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OnCall - allow more wait time options for escalation steps #1855

Merged
merged 3 commits into from
Oct 24, 2024

Conversation

mderynck
Copy link
Contributor

@mderynck mderynck commented Oct 23, 2024

Removes restrictions on wait times so any number can be entered 60-86400 seconds.

grafana/oncall#5201 must be released before this can be used.

Copy link

In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically.
To do so, a Grafana Labs employee must trigger the cloud acceptance tests workflow manually.

github-merge-queue bot pushed a commit to grafana/oncall that referenced this pull request Oct 23, 2024
# What this PR does
Remove restriction on wait times when changing escalation step wait
times. 60-86400 seconds values are accepted.

grafana/terraform-provider-grafana#1855 removes
the restriction in the terraform provider.

## Which issue(s) this PR closes

Related to: grafana/support-escalations#13065

<!--
*Note*: If you want the issue to be auto-closed once the PR is merged,
change "Related to" to "Closes" in the line above.
If you have more than one GitHub issue that this PR closes, be sure to
preface
each issue link with a [closing
keyword](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests#linking-a-pull-request-to-an-issue).
This ensures that the issue(s) are auto-closed once the PR has been
merged.
-->

## Checklist

- [x] Unit, integration, and e2e (if applicable) tests updated
- [x] Documentation added (or `pr:no public docs` PR label added if not
required)
- [x] Added the relevant release notes label (see labels prefixed w/
`release:`). These labels dictate how your PR will
    show up in the autogenerated release notes.
@mderynck mderynck marked this pull request as ready for review October 24, 2024 20:28
@mderynck mderynck requested a review from a team as a code owner October 24, 2024 20:28
@mderynck mderynck requested a review from a team October 24, 2024 20:28
@mderynck mderynck merged commit 1964031 into main Oct 24, 2024
26 checks passed
@mderynck mderynck deleted the mderynck/oncall-allow-more-wait-times branch October 24, 2024 20:29
fridgepoet pushed a commit that referenced this pull request Oct 28, 2024
* OnCall - allow more wait time options for escalation steps

* Update docs

* Update docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants