Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend: Implement Lucene raw_data queries in the backend #196

Closed
Tracked by #192
idastambuk opened this issue Jun 8, 2023 · 0 comments · Fixed by #203
Closed
Tracked by #192

Backend: Implement Lucene raw_data queries in the backend #196

idastambuk opened this issue Jun 8, 2023 · 0 comments · Fixed by #203

Comments

@idastambuk
Copy link
Contributor

idastambuk commented Jun 8, 2023

Note: Blocked by #196

Currently, Lucene raw_data queries are processed as Lucene logs (

processResponseToDataFrames(
) (frontend). This flow needs to be compared and migrated to the backend.
On the backend, raw_data is processed in the backend in getTimeSeries but is incomplete. It will need to be separated: See this ElasticSearch refactor PR and grafana/grafana#59741

Some general guidelines are:

  • Create visualization to compare between frontend and backend flows, preferably in a shared Cloud dashboard e.g. clouddatasources.grafana.net
  • Unit tests in the frontend should be copied or updated in the backend to assert the same behavior and add unit tests when there are none.
    • Check Elasticsearch repo for related tests – helpful when there are no OpenSearch tests in the frontend or backend
  • We should match OpenSearch's backend behavior to the current frontend behavior, but be aware it may not always make sense. Elasticsearch's current behavior is also another resource for how OpenSearch should behave.
    • Let's be pragmatic about this – our foremost goal is the migration of OpenSearch's frontend behavior. We can aim for some Elasticsearch feature parity, but only within reason.
  • Often there is a PR in the Elasticsearch backend data source migration Elasticsearch: Convert the datasource to be a backend datasource grafana#54011 which is 75% of what OpenSearch will need
  • Migrate or implement: i.e. make any changes to code in backend
  • Use the dashboard created above to compare visualization results (data frame comparison)
    • Can also inspect data frame on a more detailed basis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants