Fix: Take into account raw_data query's Size and Order #210
+21
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fridgepoet
changed the title
fridgepoet
requested review from
iwysiu and
idastambuk
and removed request for
a team
idastambuk
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This fixes the backend parsing of the Size for a raw_data query in the Query Editor UI.
Size is a string, not an int.
Currently the behavior defaults to a Size of 500, effectively ignoring whatever the user inputs.
With the changes in the PR, the Size is now taken into account.
This PR also takes into account the user-selected Order: descending or ascending.
Currently it is set to Descending.
With the changes in the PR, the selected Order is now taken into account.
Which issue(s) this PR fixes:
Contributes to #196