Skip to content
This repository has been archived by the owner on Jul 19, 2023. It is now read-only.

Reactivate log and metrics server instrumentation. #231

Closed
cyriltovena opened this issue Sep 16, 2022 · 0 comments · Fixed by #439
Closed

Reactivate log and metrics server instrumentation. #231

cyriltovena opened this issue Sep 16, 2022 · 0 comments · Fixed by #439
Assignees
@cyriltovena
Labels
area/database kind/chore

Comments

@cyriltovena
Copy link
Collaborator

In #226 we have started using bidi connect stream, however when logging (and may be metrics) middleware are activated (default), stream are getting stuck while communicating.

We should investigate and rewire.
@cyriltovena cyriltovena self-assigned this Nov 30, 2022
cyriltovena added a commit that referenced this issue Nov 30, 2022
@cyriltovena
Fixes http2 instrumentation.
0a11731 
Since #226 we lost automatic http log and metrics. This PR re-introduce it
by fixing the faulty middleware (log).

Fixes #231
@cyriltovena cyriltovena mentioned this issue Nov 30, 2022
Merged
simonswine pushed a commit to simonswine/pyroscope that referenced this issue Jun 30, 2023
@cyriltovena
Fixes http2 instrumentation.
f302cdb 
Since grafana/phlare#226 we lost automatic http log and metrics. This PR re-introduce it
by fixing the faulty middleware (log).

Fixes grafana/phlare#231
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cyriltovena cyriltovena

Labels
area/database kind/chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes http2 instrumentation. grafana/phlare
1 participant
@cyriltovena