Skip to content
This repository has been archived by the owner on Jul 19, 2023. It is now read-only.

Stacktraces Merge Iterator #226

Merged
merged 38 commits into from
Sep 22, 2022
Merged

Stacktraces Merge Iterator #226

merged 38 commits into from
Sep 22, 2022

Conversation

cyriltovena
Copy link
Collaborator

@cyriltovena cyriltovena commented Sep 14, 2022 •
edited
Loading

The idea of this PR is to avoid sending all samples to the querier but instead send profiles, querier select which one to aggregate, ingester returns the result of the aggregations.

simonswine
simonswine reviewed Sep 14, 2022
View reviewed changes
pkg/querier/querier.go Outdated Show resolved Hide resolved
@cyriltovena
Copy link
Collaborator Author

Getting closer to having good performance for flamegraph !

@cyriltovena
Copy link
Collaborator Author

Time to clean up ! I think this is it.

@cyriltovena cyriltovena changed the title Sample merge iterator Stacktrace Merge iterator Sep 16, 2022
@cyriltovena cyriltovena changed the title Stacktrace Merge iterator Stacktraces Merge iterator Sep 16, 2022
@cyriltovena cyriltovena changed the title Stacktraces Merge iterator Stacktraces Merge Iterator Sep 16, 2022
@cyriltovena cyriltovena mentioned this pull request Sep 16, 2022
Closed
@cyriltovena cyriltovena marked this pull request as ready for review September 17, 2022 00:29
@cyriltovena cyriltovena mentioned this pull request Sep 20, 2022
Merged
simonswine
simonswine approved these changes Sep 20, 2022
View reviewed changes
Copy link
Collaborator

@simonswine simonswine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pkg/firedb/firedb.go Show resolved Hide resolved
pkg/firedb/firedb.go Outdated Show resolved Hide resolved
simonswine
simonswine reviewed Sep 21, 2022
View reviewed changes
pkg/firedb/firedb.go Outdated Show resolved Hide resolved
@simonswine simonswine mentioned this pull request Sep 21, 2022
Merged
simonswine and others added 3 commits September 21, 2022 14:08
@simonswine
Merge pull request #239 from grafana/20220920_bidi-method
3e9e1ad 
Add unit tests for MergeProfilesStacktraces
@cyriltovena @simonswine
Update pkg/firedb/firedb.go
1e27ad0 
Co-authored-by: Christian Simon <simon@swine.de>
@cyriltovena @simonswine
Update pkg/firedb/firedb.go
5101f1e 
Co-authored-by: Christian Simon <simon@swine.de>
@cyriltovena cyriltovena merged commit a97617e into main Sep 22, 2022
@cyriltovena cyriltovena deleted the sample-merge-iterator branch September 22, 2022 08:54
cyriltovena added a commit that referenced this pull request Nov 30, 2022
@cyriltovena
Fixes http2 instrumentation.
0a11731 
Since #226 we lost automatic http log and metrics. This PR re-introduce it
by fixing the faulty middleware (log).

Fixes #231
@cyriltovena cyriltovena mentioned this pull request Nov 30, 2022
Merged
simonswine pushed a commit to simonswine/pyroscope that referenced this pull request Jun 30, 2023
@cyriltovena
Merge pull request grafana/phlare#226 from grafana/sample-merge-iterator
fbc307e 
Stacktraces Merge Iterator
simonswine pushed a commit to simonswine/pyroscope that referenced this pull request Jun 30, 2023
@cyriltovena
Fixes http2 instrumentation.
f302cdb 
Since grafana/phlare#226 we lost automatic http log and metrics. This PR re-introduce it
by fixing the faulty middleware (log).

Fixes grafana/phlare#231
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@simonswine simonswine simonswine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cyriltovena @simonswine