This repository has been archived by the owner on Jul 19, 2023. It is now read-only.
enhancement(helm): add note in resources section regarding max block duration #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…duration Signed-off-by: Conor Evans <coevans@tcd.ie>
|
FYI @simonswine 👋 |
simonswine
approved these changes
Nov 24, 2022
| # lines, adjust them as necessary, and remove the curly braces after 'resources'. | ||
| # | ||
| # Note that if memory consumption is higher than you would like, you can decrease the interval | ||
| # that profiles are written into blocks by setting `-phlaredb.max-block-duration` in the `extraArgs` |
There was a problem hiding this comment.
I think a full example yaml would be even more helpful. What do you think if do it like this?
Suggested change
| # that profiles are written into blocks by setting `-phlaredb.max-block-duration` in the `extraArgs` | |
| # that profiles are written into blocks by setting `-phlaredb.max-block-duration` in the `extraArgs` | |
| extraArgs: | |
| phlaredb.max-block-duration: 30m |
Signed-off-by: Conor Evans <coevans@tcd.ie>
simonswine
added a commit
to simonswine/pyroscope
that referenced
this pull request
Jun 30, 2023
…re-423 enhancement(helm): add note in resources section regarding max block duration
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Conor Evans coevans@tcd.ie
Implements comment from grafana/pyroscope#2083