Skip to content
This repository has been archived by the owner on Jul 19, 2023. It is now read-only.

enhancement(helm): add note in resources section regarding max block duration #435

Merged
merged 2 commits into from
Dec 7, 2022
Merged

enhancement(helm): add note in resources section regarding max block duration #435

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
947f288
enhancement(helm): add note in resources section regarding max block …
conorevans Nov 23, 2022
3d34430
enhancement: incorporate PR feedback
conorevans Dec 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion operations/phlare/helm/phlare/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,12 @@ phlare:
# We usually recommend not to specify default resources and to leave this as a conscious
# choice for the user. This also increases chances charts run on environments with little
# resources, such as Minikube. If you do want to specify resources, uncomment the following
# lines, adjust them as necessary, and remove the curly braces after 'resources:'.
# lines, adjust them as necessary, and remove the curly braces after 'resources'.
#
# Note that if memory consumption is higher than you would like, you can decrease the interval
# that profiles are written into blocks by setting `-phlaredb.max-block-duration` in the `extraArgs`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a full example yaml would be even more helpful. What do you think if do it like this?

Suggested change
# that profiles are written into blocks by setting `-phlaredb.max-block-duration` in the `extraArgs`
# that profiles are written into blocks by setting `-phlaredb.max-block-duration` in the `extraArgs`
extraArgs:
phlaredb.max-block-duration: 30m

# stanza. By default, it is set to 3h - override it with `-phlaredb.max-block-duration=30m`, for example.
#
# limits:
# cpu: 100m
# memory: 128Mi
Expand Down