Create Plugins: Use non dev docker image on e2e (#883)

grafana · Apr 24, 2024 · a6b44be · a6b44be
1 parent ae160a7
commit a6b44be
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/docusaurus/docs/get-started/set-up-development-environment.mdx b/docusaurus/docs/get-started/set-up-development-environment.mdx
@@ -142,7 +142,8 @@ services:
  build:
  context: ./.config
  args:
- development: "false"
+ development: ${DEVELOPMENT:-true}
 ```
 
 Doing that, the docker environment will only run grafana and load the content of your projects `dist` directory. Thefore before doing that you should build your plugin with `mage -v build:backend` and <SyncCommand cmd="run server" /> to generate the plugin files.
+In the example you can also use the `DEVELOPMENT` environment variable to control the development mode.
diff --git a/packages/create-plugin/templates/common/docker-compose.yaml b/packages/create-plugin/templates/common/docker-compose.yaml
@@ -11,6 +11,7 @@ services:
  args:
  grafana_image: ${GRAFANA_IMAGE:-{{~grafanaImage~}} }
  grafana_version: ${GRAFANA_VERSION:-{{~grafanaVersion~}} }
+ development: ${DEVELOPMENT:-true}
  ports:
  - 3000:3000/tcp
 {{#if hasBackend}}

diff --git a/packages/create-plugin/templates/github/ci/.github/workflows/ci.yml b/packages/create-plugin/templates/github/ci/.github/workflows/ci.yml
@@ -176,7 +176,7 @@ jobs:
  - name: Start Grafana
  run: |
  docker-compose pull
- GRAFANA_VERSION=$\{{ matrix.GRAFANA_IMAGE.VERSION }} GRAFANA_IMAGE=$\{{ matrix.GRAFANA_IMAGE.NAME }} docker-compose up -d
+ DEVELOPMENT=false GRAFANA_VERSION=$\{{ matrix.GRAFANA_IMAGE.VERSION }} GRAFANA_IMAGE=$\{{ matrix.GRAFANA_IMAGE.NAME }} docker-compose up -d
 
  - name: Wait for Grafana to start
  uses: nev7n/wait_for_response@v1