-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Plugins: Use non dev docker image on e2e #883
Conversation
@oshirohugo has there been complaints about the e2e being slow in CI? Even though the dev build is heavier, it can be really useful getting the detailed error messages in frontend and backend while troubleshooting issues. So I think we should using the development mode by default. Would be nice to add a note in the CI guide on how to disable development mode though. |
@sunker, thank you for your review. There was one complain: https://raintank-corp.slack.com/archives/C024NL6AEJH/p1711627185261299 It was not specifically about the e2e, it was regarding the time to build the development image in general. But if you think the benefits of having the development mode is greater, I can make it the default in e2e, no problem. Just let me know :D. |
Okay I see. If we could use development mode in e2e, but not install delve that would be great. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had a closer look at this PR and I think this change makes sense! Thanks for raising this pr.
🚀 PR was released in |
What this PR does / why we need it:
docker-compose.yaml
template to add the possibility to run commandsDEVELOPMENT=false docker compose up -d
to easily disable the development mode in our docker environment.📦 Published PR as canary version:
Canary Versions
✨ Test out this PR locally via:
npm install @grafana/create-plugin@4.8.0-canary.883.4c6a829.0 npm install @grafana/plugin-e2e@1.2.0-canary.883.4c6a829.0 # or yarn add @grafana/create-plugin@4.8.0-canary.883.4c6a829.0 yarn add @grafana/plugin-e2e@1.2.0-canary.883.4c6a829.0