Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Plugins: Use non dev docker image on e2e #883

Merged
merged 4 commits into from
Apr 24, 2024

Conversation

oshirohugo
Copy link
Contributor

@oshirohugo oshirohugo commented Apr 18, 2024

What this PR does / why we need it:

  1. This PR changes the docker-compose.yaml template to add the possibility to run commands DEVELOPMENT=false docker compose up -d to easily disable the development mode in our docker environment.
  2. Change the e2e ci template to use the non development docker image which is lighter and faster to build than the development one.
📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @grafana/create-plugin@4.8.0-canary.883.4c6a829.0
npm install @grafana/plugin-e2e@1.2.0-canary.883.4c6a829.0
# or 
yarn add @grafana/create-plugin@4.8.0-canary.883.4c6a829.0
yarn add @grafana/plugin-e2e@1.2.0-canary.883.4c6a829.0

@oshirohugo oshirohugo requested a review from a team as a code owner April 18, 2024 09:25
@oshirohugo oshirohugo requested review from mckn and removed request for a team April 18, 2024 09:25
Copy link

github-actions bot commented Apr 18, 2024

Hello! 👋 This repository uses Auto for releasing packages using PR labels.

✨ This PR can be merged and will trigger a new minor release.
NOTE: When merging a PR with the release label please avoid merging another PR. For further information see here.

@oshirohugo oshirohugo added minor Increment the minor version when merged release Create a release when this pr is merged create-plugin related to the create-plugin tool labels Apr 18, 2024
@oshirohugo oshirohugo self-assigned this Apr 18, 2024
@oshirohugo oshirohugo requested a review from sunker April 18, 2024 09:50
@sunker
Copy link
Contributor

sunker commented Apr 19, 2024

@oshirohugo has there been complaints about the e2e being slow in CI? Even though the dev build is heavier, it can be really useful getting the detailed error messages in frontend and backend while troubleshooting issues. So I think we should using the development mode by default. Would be nice to add a note in the CI guide on how to disable development mode though.

@oshirohugo
Copy link
Contributor Author

oshirohugo commented Apr 19, 2024

@sunker, thank you for your review. There was one complain:

https://raintank-corp.slack.com/archives/C024NL6AEJH/p1711627185261299

It was not specifically about the e2e, it was regarding the time to build the development image in general.

But if you think the benefits of having the development mode is greater, I can make it the default in e2e, no problem. Just let me know :D.

@sunker
Copy link
Contributor

sunker commented Apr 24, 2024

Okay I see. If we could use development mode in e2e, but not install delve that would be great.

Copy link
Contributor

@sunker sunker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a closer look at this PR and I think this change makes sense! Thanks for raising this pr.

@oshirohugo oshirohugo merged commit a6b44be into main Apr 24, 2024
13 checks passed
@oshirohugo oshirohugo deleted the use-non-dev-docker-image-on-e2e branch April 24, 2024 09:05
@grafana-plugins-platform-bot
Copy link

🚀 PR was released in @grafana/create-plugin@4.8.0, @grafana/plugin-e2e@1.2.0 🚀

@grafana-plugins-platform-bot grafana-plugins-platform-bot bot added the released This issue/pull request has been released. label Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
create-plugin related to the create-plugin tool minor Increment the minor version when merged release Create a release when this pr is merged released This issue/pull request has been released.
Projects
Development

Successfully merging this pull request may close these issues.

2 participants