Feature: Support for css/sass files #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackw
added
enhancement
jackw
changed the title
academo
approved these changes
Oct 21, 2022
…et/resource usage
…cate . from img font filenames
jackw
force-pushed
the
jackw/css-files-support
branch
from
43be7ed
to
bc1232c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Currently create-plugin doesn't support CSS other than
@emotion/csshowever there are plugins out there that either have css files or use libraries that have css files.This PR:
null->undefined) and changes libraryTarget to library.typeWhich issue(s) this PR fixes:
Fixes #97
Special notes for your reviewer: