Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Don't ignore node_modules css files #106

Merged
merged 1 commit into from
Oct 24, 2022
Merged

Fix: Don't ignore node_modules css files #106

merged 1 commit into from
Oct 24, 2022

Conversation

jackw
Copy link
Collaborator

@jackw jackw commented Oct 21, 2022

What this PR does / why we need it:
Follow up to #103 which accidentally ignored css in node_modules which will cause npm packages with css to fail to build.

Which issue(s) this PR fixes:

Fixes #97

Special notes for your reviewer:

@jackw jackw added the create-plugin related to the create-plugin tool label Oct 21, 2022
@jackw jackw requested a review from academo October 21, 2022 15:19
@jackw jackw self-assigned this Oct 21, 2022
@jackw jackw added this to the v1.0.0 milestone Oct 23, 2022
Copy link
Collaborator

@leventebalogh leventebalogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Collaborator

@mckn mckn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jackw jackw merged commit dd74459 into main Oct 24, 2022
@jackw jackw deleted the jackw/fix-css-again branch October 24, 2022 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
create-plugin related to the create-plugin tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Cannot build css files
3 participants