Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sign-Plugin: Clean up, improve error messages, add basic CI steps #117

Merged
merged 11 commits into from
Oct 26, 2022
Merged

Sign-Plugin: Clean up, improve error messages, add basic CI steps #117

merged 11 commits into from
Oct 26, 2022

Conversation

jackw
Copy link
Collaborator

@jackw jackw commented Oct 26, 2022

What this PR does / why we need it:
This PR tries to clean up sign-plugin to get it in a state where we can cut a first release.

  • Make sure file path is cross-platform compatible when getting sign-plugin version from package.json
  • Clean up typings
  • Improve errors
  • Sanitise file paths in manifest so windows doesn't create invalid manifests
  • Remove redundant commands code from bin file
  • Introduce steps to sign a generated plugin in CI

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@jackw jackw added the sign-plugin Changes related to sign-plugin label Oct 26, 2022
@jackw jackw added this to the v1.0.0 milestone Oct 26, 2022
@jackw jackw self-assigned this Oct 26, 2022
@jackw jackw changed the title Sign-Plugin: Clean up code, improve error messages, add basic CI steps Sign-Plugin: Clean up, improve error messages, add basic CI steps Oct 26, 2022
@jackw jackw added the enhancement New feature or request label Oct 26, 2022
academo
academo approved these changes Oct 26, 2022
View reviewed changes
Copy link
Member

@academo academo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excelent work!

mckn
mckn approved these changes Oct 26, 2022
View reviewed changes
Copy link
Collaborator

@mckn mckn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jackw jackw merged commit 0ddbbb9 into main Oct 26, 2022
@jackw jackw deleted the jackw/sign-plugin-cleanup branch October 26, 2022 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@academo academo academo approved these changes

@mckn mckn mckn approved these changes

@leventebalogh leventebalogh Awaiting requested review from leventebalogh

Assignees

@jackw jackw

Labels
enhancement New feature or request sign-plugin Changes related to sign-plugin
Projects
Plugins Platform / Grafana Community
Archived in project
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jackw @mckn @academo