Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sign-Plugin: Clean up, improve error messages, add basic CI steps #117

Merged
merged 11 commits into from
Oct 26, 2022
Merged

Sign-Plugin: Clean up, improve error messages, add basic CI steps #117

merged 11 commits into from
Oct 26, 2022

Commits on Oct 25, 2022

  1. refactor(sign-plugin): make sure file path is cross-platform compatible

    @jackw
    jackw committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    ba4c5c3 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2022

  1. refactor(sign-plugin): clean up typings in manifest.ts

    @jackw
    jackw committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    4d2f50a View commit details
    Browse the repository at this point in the history

  2. refactor(sign-plugin): remove redundant async and catch errors when w… 

    …riting manifest file
    @jackw
    jackw committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    e115359 View commit details
    Browse the repository at this point in the history

  3. chore(sign-plugin): improve errors when attempting to sign manifest

    @jackw
    jackw committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    e177e01 View commit details
    Browse the repository at this point in the history

  4. fix(sign-plugin): sanitise file paths in manifest so windows doesn't … 

    …create invalid manifests
    @jackw
    jackw committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    10a1269 View commit details
    Browse the repository at this point in the history

  5. chore(sign-plugin): add error message if plugin dist directory doesn'… 

    …t exist
    @jackw
    jackw committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    c39c6f7 View commit details
    Browse the repository at this point in the history

  6. chore(sign-plugin): remove redundant commands from bin

    @jackw
    jackw committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    54ffa13 View commit details
    Browse the repository at this point in the history

  7. ci(sign-plugin): introduce steps to sign a generated plugin

    @jackw
    jackw committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    14762f3 View commit details
    Browse the repository at this point in the history

  8. chore(github): remove stray double quote

    @jackw
    jackw committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    27a57b1 View commit details
    Browse the repository at this point in the history

  9. refactor(test): update to get sign step working

    @jackw
    jackw committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    972a0a6 View commit details
    Browse the repository at this point in the history

  10. ci(test): make sure to build sign-plugin before validating

    @jackw
    jackw committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    c9f242e View commit details
    Browse the repository at this point in the history