Plugin E2E: Enable testing the variable editor #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! 👋 This repository uses Auto for releasing packages using PR labels. ✨ This PR can be merged. It will not be considered when calculating future versions of the npm packages and will not appear in the changelogs. |
sunker
added
the
no-changelog
sunker
force-pushed
the
variable-editor
branch
2 times, most recently
from
349427d
to
481446e
Compare
sunker
force-pushed
the
variable-editor
branch
from
e3dfea5
to
6e38d96
Compare
sunker
changed the title
jackw
approved these changes
Dec 11, 2023
packages/plugin-e2e/src/api.ts
Outdated
| * | ||
| * Use {@link PanelEditPage.setVisualization} to change the visualization | ||
| * Use {@link PanelEditPage.datasource.set} to change the datasource | ||
| * Use {@link PanelEditPage.datasource.set} to change the |
There was a problem hiding this comment.
nit: should this change should be reverted?
academo
reviewed
Dec 11, 2023
academo
reviewed
Dec 11, 2023
academo
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds fixtures, models and expect matchers that enable testing a custom variable query editor and the variable query runner in a data source plugin.
Please not that the playwright tests under
packages/plugin-e2e/testsare not actually part of the plugin-e2e package. They are there to test the features that are exposed by the package. They can also function as a spec of how the package can be used. We may want to move them to plugin-examples eventually.Which issue(s) this PR fixes:
Part of #576
Fixes #
Special notes for your reviewer: