Plugin E2E: Enable testing the annotation editor #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! 👋 This repository uses Auto for releasing packages using PR labels. ✨ This PR can be merged. It will not be considered when calculating future versions of the npm packages and will not appear in the changelogs. |
sunker
changed the title
sunker
added
the
no-changelog
sunker
changed the title
academo
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds fixtures and models that enable testing the annotation query editor and the annotation query runner in a data source plugin. The setup is very similar to variable editor tests.
Which issue(s) this PR fixes:
Part of #576
Fixes #
Special notes for your reviewer:
It's on my todolist to ask the dashboard squad for a direct URL to the page for editing a new annotation. It would be nice so we don't have to navigate via the dashboard annotation page which is slow and could be prone to errors. However, if we manage to get a new URL we'd still need this code since plugin-e2e needs to be backwards compatible with older versions of Grafana.