Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serve assets gzipped #342

Closed
petethepig opened this issue Aug 20, 2021 · 5 comments
Closed

Serve assets gzipped #342

petethepig opened this issue Aug 20, 2021 · 5 comments
Assignees
@gawicks
Labels
backend Mostly go code

Comments

@petethepig
Copy link
Member

I think pyroscope should serve assets gzipped
@petethepig petethepig added the backend Mostly go code label Aug 20, 2021
@gawicks
Copy link
Contributor

gawicks commented Aug 30, 2021 •
edited
Loading

Hi @petethepig it's @gawicks from slack. Please assign me to this issue.

@petethepig petethepig assigned petethepig and gawicks and unassigned petethepig Aug 30, 2021
@petethepig
Copy link
Member Author

Done. Thanks for the help, it's much appreciated!

gawicks added a commit to gawicks/pyroscope that referenced this issue Sep 6, 2021
@gawicks
serve assets gzipped grafana#342
91bfc58
petethepig pushed a commit that referenced this issue Sep 8, 2021
@gawicks
serve assets gzipped #342 (#381)
0039ec5 
* serve assets gzipped #342

* Extract method getHandler to make asset compression testable

* Tests: Asset compression
@gawicks
Copy link
Contributor

gawicks commented Sep 8, 2021

@petethepig Looks like there's some housekeeping left. Could you link PR #381 to this issue and close 😊

@petethepig
Copy link
Member Author

@gawicks Right, I always forget, thanks for the reminder!

@petethepig
Copy link
Member Author

Fixed in #381

korniltsev pushed a commit that referenced this issue Jul 18, 2023
@cyriltovena
Merge pull request #342 from grafana/logo
1abd2af 
Add logos
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gawicks gawicks

Labels
backend Mostly go code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@petethepig @gawicks