Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

serve assets gzipped #342 #381

Merged
merged 3 commits into from
Sep 8, 2021
Merged

serve assets gzipped #342 #381

merged 3 commits into from
Sep 8, 2021

Conversation

gawicks
Copy link
Contributor

@gawicks gawicks commented Sep 6, 2021

No description provided.

@CLAassistant
Copy link

CLAassistant commented Sep 6, 2021

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Sep 6, 2021

Codecov Report

Merging #381 (3aa6a6a) into main (e14038f) will increase coverage by 0.81%.
The diff coverage is 37.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #381      +/-   ##
==========================================
+ Coverage   50.26%   51.07%   +0.81%     
==========================================
  Files         117      117              
  Lines        5239     5258      +19     
==========================================
+ Hits         2633     2685      +52     
+ Misses       2355     2310      -45     
- Partials      251      263      +12     
Impacted Files Coverage Δ
pkg/server/controller.go 45.74% <37.50%> (-0.12%) ⬇️
pkg/agent/upstream/remote/remote.go 62.32% <0.00%> (-2.89%) ⬇️
pkg/server/handler.go 2.55% <0.00%> (+1.91%) ⬆️
pkg/cli/flags.go 66.07% <0.00%> (+2.72%) ⬆️
pkg/cli/command.go 56.76% <0.00%> (+56.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0f491e...3aa6a6a. Read the comment docs.

@gawicks gawicks marked this pull request as draft September 6, 2021 05:01
@gawicks
Copy link
Contributor Author

gawicks commented Sep 6, 2021

Setting this to WIP till I've written some tests.

@gawicks
Copy link
Contributor Author

gawicks commented Sep 6, 2021

@petethepig I'd like some feedback on the use of klauspost/compress library.

@petethepig
Copy link
Member

It looks good! I tried running it too and it seems to be working as expected. My original plan was to only enable it for everything in /assets, but then I thought about it and I figured this even better actually.

@petethepig
Copy link
Member

@gawicks Oh, and regarding the library, I do think it makes sense to use it here.

@gawicks gawicks marked this pull request as ready for review September 7, 2021 14:43
@gawicks
Copy link
Contributor Author

gawicks commented Sep 7, 2021

@petethepig Thanks! I've finished adding tests. The PR is ready for review.

@petethepig
Copy link
Member

@gawicks Looks good! Cool use of DescribeTable, I didn't know you could do that :)

@petethepig petethepig merged commit 0039ec5 into grafana:main Sep 8, 2021
@gawicks
Copy link
Contributor Author

gawicks commented Sep 8, 2021

Yay!

@gawicks gawicks mentioned this pull request Sep 8, 2021
korniltsev pushed a commit that referenced this pull request Jul 18, 2023
Update issue templates to add a feature request template
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants