fix: disable Go names decoration

[kolesnikovae]

Starting from Go 1.21.0, type parameters are part of the function name in pprof, which often makes them unreadable

The change reverts #2343 (replaces Go type parameters with ellipses [...]) as it makes it impossible to find the selected node in the source profile in backend (needed for #2228, and #2727 and https://github.com/grafana/pyroscope-app-plugin/issues/207).

The presentation aspects are to be managed on the frontend. Ideally, there should be an option for user to disable all the decorations. Note that a function name change usually causes changes in the tree/flamegraph structure, which we used to fix. I believe we don't have to do this.

[cyriltovena]

cc @aocenas We're going to need some sort of function sanitizer on the frontend but still able to access to original function for programatic need.

[aocenas]

@cyriltovena I assume we could just port this function https://github.com/grafana/pyroscope/pull/2343/files#diff-e7b8e2da222a25feb1fdc03174dd0d9783102c532048d0bd2945ab9ef6c87c8bR10 to the frontend right? Is it safe to apply to any code (non Go code)? It seems like @kolesnikovae suggests as much in the comment but wonder if there is some caveat or not.

[cyriltovena]

I would not do it for any other language just in case I suggest we found this [go.shape......] and replace it with [...] that should be good enough and only appear in go.

Again the original must still be accessible on click event.

[cyriltovena]

connectrpc.com/connect.NewUnaryHandler[go.shape.struct { github.com/grafana/pyroscope/api/gen/proto/go/types/v1.state google.golang.org/protobuf/internal/impl.MessageState; github.com/grafana/pyroscope/api/gen/proto/go/types/v1.sizeCache int32; github.com/grafana/pyroscope/api/gen/proto/go/types/v1.unknownFields []uint8; Matchers []string "protobuf:\"bytes,1,rep,name=matchers,proto3\" json:\"matchers,omitempty\""; Start int64 "protobuf:\"varint,2,opt,name=start,proto3\" json:\"start,omitempty\""; End int64 "protobuf:\"varint,3,opt,name=end,proto3\" json:\"end,omitempty\"" },go.shape.struct { github.com/grafana/pyroscope/api/gen/proto/go/types/v1.state google.golang.org/protobuf/internal/impl.MessageState; github.com/grafana/pyroscope/api/gen/proto/go/types/v1.sizeCache int32; github.com/grafana/pyroscope/api/gen/proto/go/types/v1.unknownFields []uint8; Names []string "protobuf:\"bytes,1,rep,name=names,proto3\" json:\"names,omitempty\"" }].func2

[aocenas]

I would not do it for any other language just in case

Yeah but we still don't have any information about the language from the backend do we?