fix: drop type params from Go function names

[kolesnikovae]

This change involves the removal of type parameters from Go function names during the ingestion process.

The primary rationale behind this modification is that, in Go, function type parameters within profiles are often encountered in unexpected code paths. Allegedly, the Go profiler does not consider the call site when constructing the function name and may include parameters from irrelevant function instantiations. This behavior significantly increases the cardinality of stack traces. For more details, please refer to #2241, specifically this comment.

The elimination of type parameters results in a reduction of cardinality by up to 50% (ingester's heap, 1 hour):

	fix_test.go:24:  * Sample:     6785 -> 3797
	fix_test.go:25:  * Location:   4848 -> 4680
	fix_test.go:26:  * Function:   2801 -> 2724
	fix_test.go:27:  * Strings:    3536 -> 3458

Regarding the impact on PGO: given that we cannot rely on the parameters, no negative impact is expected.

We probably should be more specific about the Go version, but we do not have this information yet. Theoretically, we only have to do this for go < 1.22 / 1.21.6.

Related:

• go1.21.0 pprof function names #2241
• Remove type parameters from go names #2343
• fix: disable Go names decoration #2976 (revert of 2343)

Go:

• runtime/pprof: incorrect function names for generics functions golang/go#64528 (fix)
• runtime/pprof: incorrect locations for inlined generic functions golang/go#64641
• runtime/pprof: unexpectedly seeing full struct definitions in function names for generics functions golang/go#65147

[cyriltovena]

LGTM

Can't wait to try this out in our biggest cluster. Do you know if there's a report of that bug somewhere in the go community ?

[simonswine]

@cyriltovena it is linked in the top comment under Go:

[cyriltovena]

I'm blind today ! sorry.