Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/autumn clean #1005

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Chore/autumn clean #1005

merged 2 commits into from
Dec 3, 2024

Conversation

ckbedwell
Copy link
Contributor

Problem

There are quite a few artifacts lying around the repository which are no longer used or needed. There are also several places where mocked files are being used for jest that can be difficult to track down and identify.

Solution

Remove any of the old and unused files and references to them (such as cspell -- not against bringing this back in the future if we deem appropriate but it isn't even a package we download or use).

Re-locate the test mocks to the test/mocks folder to make easier dx for understanding how our tests work.

@ckbedwell ckbedwell requested a review from a team as a code owner November 26, 2024 16:11
@ckbedwell ckbedwell requested review from w1kman and VikaCep November 26, 2024 16:14
Copy link
Contributor

@w1kman w1kman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🧹

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😢

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll bring it back in the near future 😄

@ckbedwell ckbedwell merged commit 279272d into main Dec 3, 2024
5 checks passed
@ckbedwell ckbedwell deleted the chore/autumn-clean branch December 3, 2024 09:12
VikaCep added a commit that referenced this pull request Dec 19, 2024
VikaCep added a commit that referenced this pull request Dec 19, 2024
* Revert "refactor: move ChooseCheckGroup to page folder (#1021)"

This reverts commit cf67891.

* Revert "Feat: Add RBAC to Synthetic Monitoring (#982)"

This reverts commit a41e15f.

* Revert "chore(main): release 1.16.10 (#1015)"

This reverts commit 92350bd.

* Revert "Chore: update checks UI styling (#1020)"

This reverts commit 2b69b02.

* Revert "chore(deps): bump nanoid from 3.3.7 to 3.3.8 (#1018)"

This reverts commit 77032d0.

* Revert "Feat: prompt on unsaved unload (#1002)"

This reverts commit 9747b27.

* Revert "fix: add synthetic-monitoring-dev as owners of release files (#1010)"

This reverts commit d703e42.

* Revert "Chore/autumn clean (#1005)"

This reverts commit 279272d.

* fix: update package version

* fix: bring back changelog entries from 1.16.10

* fix: change release-please-manifest version to 1.16.10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants