refactor: move ChooseCheckGroup to page folder #1021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VikaCep
added a commit
that referenced
this pull request
Dec 19, 2024
* Revert "refactor: move ChooseCheckGroup to page folder (#1021)" This reverts commit cf67891. * Revert "Feat: Add RBAC to Synthetic Monitoring (#982)" This reverts commit a41e15f. * Revert "chore(main): release 1.16.10 (#1015)" This reverts commit 92350bd. * Revert "Chore: update checks UI styling (#1020)" This reverts commit 2b69b02. * Revert "chore(deps): bump nanoid from 3.3.7 to 3.3.8 (#1018)" This reverts commit 77032d0. * Revert "Feat: prompt on unsaved unload (#1002)" This reverts commit 9747b27. * Revert "fix: add synthetic-monitoring-dev as owners of release files (#1010)" This reverts commit d703e42. * Revert "Chore/autumn clean (#1005)" This reverts commit 279272d. * fix: update package version * fix: bring back changelog entries from 1.16.10 * fix: change release-please-manifest version to 1.16.10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 3 of addressing: #848
Problem
ChooseCheckGroupwas in the components folder despite it being the primary page for choosing a check group in check creation.Solution
Move
ChooseCheckGroupto the page folder and its associated components. I've moved the component it utilizes appropriately to either the localised page component folder or flatten it to the global components folder.I've also separated
NewStatusBadgeto its own file rather than being another export fromCheckStatusInfo. Our component files should only have one export to one day support hot-reloading properly 🤞