Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add uid value to alert notification resource #87

Merged
merged 5 commits into from
Jun 3, 2020
Merged

Add uid value to alert notification resource #87

merged 5 commits into from
Jun 3, 2020

Conversation

58231
Copy link
Contributor

@58231 58231 commented Mar 18, 2020

This is verified working. However, It does required the following PR be completed: nytm/go-grafana-api#34

@ghost ghost added the size/XS label Mar 18, 2020
@lijok
Copy link

lijok commented Apr 28, 2020

Any chance to get this merged in asap?
Impossible to set up alarms on panels with terraform without this

@tonglil tonglil mentioned this pull request Jun 2, 2020
Closed
tonglil
tonglil approved these changes Jun 2, 2020
View reviewed changes
Copy link
Contributor

@tonglil tonglil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewing this, would you be able to resolve the conflict?

Otherwise LGTM, pending upstream library changes

@58231
Copy link
Contributor Author

58231 commented Jun 2, 2020

Once a release gets cut for github.com/nytm/go-grafana-api (PR just got merged today), I'll get this PR updated and it should clear the conflict.

@ghost ghost removed the waiting-response label Jun 2, 2020
@mlclmj
Copy link
Contributor

mlclmj commented Jun 3, 2020

Hey @58231, just released v0.5.0 which includes these changes

reugn
reugn suggested changes Jun 3, 2020
View reviewed changes
grafana/resource_alert_notification.go Outdated Show resolved Hide resolved
tonglil
tonglil approved these changes Jun 3, 2020
View reviewed changes
Copy link
Contributor

@tonglil tonglil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tonglil tonglil merged commit db481eb into grafana:master Jun 3, 2020
@tonglil tonglil mentioned this pull request Jun 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reugn reugn reugn requested changes

@tonglil tonglil tonglil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@58231 @lijok @mlclmj @tonglil @reugn @sa-githubcloudtesting