Skip to content
This repository was archived by the owner on Mar 17, 2021. It is now read-only.

add AlertNotification Uid field #34

Merged
merged 1 commit into from
Jun 2, 2020
Merged

add AlertNotification Uid field #34

merged 1 commit into from
Jun 2, 2020

Conversation

reugn
Copy link
Contributor

@reugn reugn commented Jan 22, 2020

No description provided.

@dw014081
Copy link

Would it be possible to get this PR merged and released anytime soon?

I need this enhancement so I can fix this issue[1] in the terraform-provider-grafana code base. I'm attempting to push dashboards with alerts into grafana and without the UID from alert-notification-channel I'm unable to fully automate the process.

Let me know what I can do to assist.

Thanks!

[1] https://github.com/terraform-providers/terraform-provider-grafana/issues/83

@58231
Copy link

58231 commented Mar 18, 2020 •
edited
Loading

I have a lot of Grafana automation that hinges on this. Can we get an approval please?

@58231 58231 mentioned this pull request Mar 18, 2020
Merged
@lijok
Copy link

lijok commented Apr 28, 2020

Any chance to get this merged in asap?
Impossible to set up alarms on panels with terraform without this

@giuliocalzolari
Copy link

any ETA?

tonglil
tonglil approved these changes Jun 2, 2020
View reviewed changes
Copy link
Contributor

@tonglil tonglil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @mlclmj ?

https://grafana.com/docs/grafana/latest/http_api/alerting_notification_channels/

@tonglil tonglil added the size/XS Denotes a PR that changes 0-9 lines label Jun 2, 2020
mlclmj
mlclmj approved these changes Jun 2, 2020
View reviewed changes
Copy link
Contributor

@mlclmj mlclmj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@mlclmj mlclmj merged commit fe546f5 into nytm:master Jun 2, 2020
@58231
Copy link

58231 commented Jun 2, 2020

Can we get a release cut?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tonglil tonglil tonglil approved these changes

@giuliocalzolari giuliocalzolari giuliocalzolari approved these changes

@mlclmj mlclmj mlclmj approved these changes

Assignees
No one assigned
Labels
enhancement size/XS Denotes a PR that changes 0-9 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@reugn @dw014081 @58231 @lijok @giuliocalzolari @tonglil @mlclmj