This repository has been archived by the owner on Jan 30, 2025. It is now read-only.
Fix panic on nil response during page.reload #1408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankur22
force-pushed
the
fix/1407-nil-resp-on-reload
branch
from
7a81a92 to
43a7bd7
Compare
inancgumus
approved these changes
Aug 23, 2024
Closed
This was referenced Sep 10, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Returns early from
page.reload(async API only).Why?
Avoids unnecessary panics and aborts since it is expected that response can be nil.
Checklist
Related PR(s)/Issue(s)
Updates: #1407
Linked to: #1387