Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix async reload when it returns a null response #1422

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Fix async reload when it returns a null response #1422

merged 1 commit into from
Sep 11, 2024

Conversation

ankur22
Copy link
Collaborator

@ankur22 ankur22 commented Sep 10, 2024 •
edited
Loading

What?

Avoid the null exception when reload is called a response is null.

Why?

Avoids an error that isn't an error. Response can be null.

Checklist

  • I have performed a self-review of my code
  • I have added tests for my changes
  • I have commented on my code, particularly in hard-to-understand areas

Related PR(s)/Issue(s)

Linked to: #1408
Updates: #1407

@ankur22 ankur22 requested a review from inancgumus September 10, 2024 15:37
@ankur22 ankur22 mentioned this pull request Sep 11, 2024
Merged
3 tasks
@ankur22 ankur22 merged commit 16fa159 into main Sep 11, 2024
23 checks passed
@ankur22 ankur22 deleted the fix/async-reload branch September 11, 2024 08:03
@ankur22 ankur22 mentioned this pull request Sep 13, 2024
Merged
5 tasks
@BrewTestBot BrewTestBot mentioned this pull request Sep 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inancgumus inancgumus inancgumus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ankur22 @inancgumus