Add s390x support for travis #869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not against, but is there actually anyone who will fix s390 issues if they would occur? Is it needed to duplicate all entries? Wouldn't just adding an "arch:" entry work like described here. |
|
Hi, Yes, we already build and maintain carbon on s390x. Our build instructions are published here . Regarding "Is it needed to duplicate all entries? ", if we just add "arch: " entry, only 3 travis builds are triggered for s390x for the 3 environments mentioned at " https://github.com/graphite-project/carbon/blob/master/.travis.yml#L34 " and the ones in the matrix are not triggered. Hence added it separately. |
|
Hi, any updates on the PR if the changes can be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As Travis CI officially supports s390x builds, adding support for same.