Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.1.x] s390x support for travis (#869) | Fix #871: Adjust aggregator-rules input_pattern match greediness to support numeric matching after captured field (#872) | sanitize names when using them as tag value (#858) | sanitize names when us #883

Conversation

deniszh
Copy link
Member

@deniszh deniszh commented Feb 21, 2020

Backports the following commits to 1.1.x:

sangitanalkar and others added 8 commits February 21, 2020 18:36
… greediness to support numeric matching after captured field
* sanitize names when using them as tag value

related: graphite-project/graphite-web#2458

* implement updated rules

* copy tag and value validation from graphite

* better error messages

* add tests for tag validation

* Better exception messages

Co-Authored-By: Dan Cech <dan@aussiedan.com>

Co-authored-by: Dan Cech <dan@aussiedan.com>
* Another test fix try

* Update .travis.yml

* Update .travis.yml
xenial and "sudo=true" are standard now
(https://docs.travis-ci.com/user/reference/linux/)

python-3.8 has been released, so "-dev" can be removed

also simplify install section a bit,
and adjust matrix entries so "env" is always last (for readability)
* Trying to fix tests

* Removing code, because lint is angry

* taming lint, again
This probably breaks the manhole for Python 2 and old versions of
Twisted.
@deniszh
Copy link
Member Author

deniszh commented Feb 21, 2020

Preparing 1.1.7 release

@deniszh deniszh requested review from piotr1212 and DanCech February 21, 2020 17:52
@piotr1212
Copy link
Member

pr858 is added three times? You might want to check what went wrong there.

@deniszh
Copy link
Member Author

deniszh commented Feb 23, 2020

Same thing as with 2458 in graphite-project/graphite-web#2545

It just inserting empty commits for some reason.

@deniszh
Copy link
Member Author

deniszh commented Feb 23, 2020

I mean, PR is good, despite duping

@deniszh deniszh merged commit 4c60b01 into graphite-project:1.1.x Feb 29, 2020
@deniszh deniszh deleted the backport/1.1.x/pr-869_pr-872_pr-858_pr-858_pr-858_pr-874_pr-875_pr-880_pr-881_pr-882 branch February 29, 2020 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants