Rename master branch to 0.9.x and update installation instructions
#51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonFrings
reviewed
Oct 31, 2022
README.md
Outdated
Comment on lines
7
to
14
| > **Development version:** This branch contains the code for the upcoming 0.9 release. | ||
| > For the code of the current stable 0.8 release, check out the | ||
| > [`0.8.x` branch](https://github.com/graphp/algorithms/tree/0.8.x). | ||
| > | ||
| > The upcoming 0.9 release will be the way forward for this package. | ||
| > However, we will still actively support 0.8.x for those not yet | ||
| > on the latest version. | ||
| > See also [installation instructions](#install) for more details. |
There was a problem hiding this comment.
Suggested change
| > **Development version:** This branch contains the code for the upcoming 0.9 release. | |
| > For the code of the current stable 0.8 release, check out the | |
| > [`0.8.x` branch](https://github.com/graphp/algorithms/tree/0.8.x). | |
| > | |
| > The upcoming 0.9 release will be the way forward for this package. | |
| > However, we will still actively support 0.8.x for those not yet | |
| > on the latest version. | |
| > See also [installation instructions](#install) for more details. | |
| > **Development version:** This branch contains the code for the upcoming `v0.9` release. | |
| > For the code of the current stable `v0.8` release, check out the | |
| > [`0.8.x` branch](https://github.com/graphp/algorithms/tree/0.8.x). | |
| > | |
| > The upcoming `v0.9` release will be the way forward for this package. | |
| > However, we will still actively support `0.8.x` for those not yet | |
| > on the latest version. | |
| > See also [installation instructions](#install) for more details. |
I think we should name the versions as suggested. We could also go ahead and name them v0.9.0 and v0.8.2 instead of v0.9 and v0.8, but I don't think there's much gained and we don't know for sure if v0.8.2 will be the last v0.8 release.
We could also merge the current state of your PR as is, this way it would be compatible to all other projects with the same section.
Not sure which one is really "better" here, I leave this decision up to you :)
There was a problem hiding this comment.
Updated to consistently write out "upcoming version 0.9" instead of "upcoming 0.9" or "upcoming v0.9". WDYT? 👍
clue
force-pushed
the
rename
branch
2 times, most recently
from
6c8aad9 to
8d95b90
Compare
SimonFrings
approved these changes
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of #41, graphp/graph#213 and reactphp/async#29