Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename master branch to 1.x and update installation instructions #213

Merged
merged 1 commit into from
Oct 19, 2022

Conversation

clue
Copy link
Member

@clue clue commented Oct 19, 2022

Builds on top of #166
Refs reactphp/async#29

@clue clue added this to the v1.0.0 milestone Oct 19, 2022
@clue clue requested a review from SimonFrings October 19, 2022 07:37
@llaville
Copy link

@clue Don't forget to update also https://github.com/graphp/graphviz/blob/master/composer.json#L13 to be able to install graphp/graphviz package too !

@clue
Copy link
Member Author

clue commented Oct 19, 2022

@llaville Good catch, will make sure this is updated across the @graphp organization once this PR is merged! GitHub automatically sets up redirects for old branch names, so I think the previous installations should continue to work in either case.

@SimonFrings SimonFrings merged commit e5b2802 into graphp:1.x Oct 19, 2022
@SimonFrings SimonFrings deleted the rename branch October 19, 2022 09:34
@llaville
Copy link

GitHub automatically sets up redirects for old branch names, so I think the previous installations should continue to work in either case.

@clue No it does not works when you add constraint on version with alias into a composer.json file like that :

    "require": {
        "php": "^7.4.0 || ^8.0",
        "graphp/graph": "1.x-dev#41e73a5 as 1.0.0",
        "graphp/graphviz": "dev-master#42a2098 as 1.0.0"
    },

Composer 2.4 prints

  Problem 1
    - Root composer.json requires graphp/graphviz dev-master#42a2098 as 1.0.0 -> satisfiable by graphp/graphviz[dev-master].
    - graphp/graphviz dev-master requires graphp/graph dev-master#214de45 as 1.0.0 -> found graphp/graph[dev-master] but it conflicts with your root composer.json require (1.x-dev#41e73a5 as 1.0.0).

So, please apply change on graphviz package ASAP !

@clue
Copy link
Member Author

clue commented Oct 27, 2022

@llaville See graphp/graphviz#64.

I hope this helps! 👍 If so, consider supporting this project, for example by becoming a sponsor ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants