Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Disallow grafts that are within the reorg threshold of the base subgraph #5131

Closed
leoyvens opened this issue Jan 10, 2024 · 0 comments · Fixed by #5135
Closed

[Bug] Disallow grafts that are within the reorg threshold of the base subgraph #5131

leoyvens opened this issue Jan 10, 2024 · 0 comments · Fixed by #5135
Assignees
Labels
bug Something isn't working

Comments

@leoyvens
Copy link
Collaborator

leoyvens commented Jan 10, 2024

Bug report

Currently this is allowed, but if the base subgraph reverts it can result in an inconsistent graft. This should be instead rejected at deployment time.

Relevant log output

2024-01-02T14:22:30.164887291Z stderr F Jan 02 14:22:30.164 WARN Firehose selected first streamed block's parent should match subgraph start block, reverting to last know final chain segment, firehose_start_block: #18746373 (5ca99c16915d2cd025e4fc1b3962c08eb75d171840d70116d2ff9204d3a1c5cc), subgraph_current_block: #18746373 (ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff), provider: mainnet-firehose-sf, deployment: QmXYAmabbEmnSDNR5GWJhmm2NQKXnPkSJEBC3EsMwjXr4e, sgd: 567032, subgraph_id: QmXYAmabbEmnSDNR5GWJhmm2NQKXnPkSJEBC3EsMwjXr4e, component: FirehoseBlockStream

2024-01-02T14:22:30.772869846Z stderr F Jan 02 14:22:30.772 INFO Reverting block to get back to main chain, revert_to_ptr: #18746174 (b6fc3f8b01773770b6b4e90c691df73d8baea33b49cbf49b0adffa6936d13367), subgraph_ptr: #18746373 (ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff), sgd: 567032, subgraph_id: QmXYAmabbEmnSDNR5GWJhmm2NQKXnPkSJEBC3EsMwjXr4e, component: SubgraphInstanceManager
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants