graph: Disallow grafts within the reorg threshold #5135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoyvens
approved these changes
Jan 15, 2024
lutter
force-pushed
the
lutter/graft-reorg
branch
from
bddcc9e
to
08c953b
Compare
|
I fixed the test failure in the nastiest way possible, but can't think of a better way to address it short of rewriting a lot of the subgraph runner tests. |
|
Truly heinous, I love it. But seriously, what's sad about this is that it's an admittance that we don't test this branch at all, and makes it impossible to test while the |
lutter
force-pushed
the
lutter/graft-reorg
branch
from
08c953b
to
e5afa56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5131