Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Change subgraph runner tests to not graft onto subgraph head #5197

Closed
lutter opened this issue Feb 8, 2024 · 1 comment · Fixed by #5584
Closed

[Bug] Change subgraph runner tests to not graft onto subgraph head #5197

lutter opened this issue Feb 8, 2024 · 1 comment · Fixed by #5584
Labels
bug Something isn't working good first issue Good for newcomers Stale

Comments

@lutter
Copy link
Collaborator

lutter commented Feb 8, 2024

Some of the subgraph runner tests graft directly onto the subgraph head. PR #5135 made that very verboten, which would make those tests fail. For expediency, the PR just disables the check that we graft at least reorg_threshold blocks back for debug builds.

The right fix for this would be to change the subgraph runner tests to set a small reorg threshold and to graft only outside that reorg threshold so that the check can be enabled for debug builds, too.

@lutter lutter added the bug Something isn't working label Feb 8, 2024
@leoyvens leoyvens added the good first issue Good for newcomers label Feb 9, 2024
Copy link

Looks like this issue has been open for 6 months with no activity. Is it still relevant? If not, please remember to close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers Stale
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants