This repository has been archived by the owner on Feb 23, 2023. It is now read-only.
Expose reverts to mappings #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 28, 2019
Jannis
suggested changes
Sep 2, 2019
index.ts
Outdated
| let result = ethereum.call(call) | ||
| assert( | ||
| result != null, | ||
| 'Call reverted, consider using `try_' + name + '` to handle this in the mapping.', |
There was a problem hiding this comment.
Let's make this even more useful by mentioning that this usually means an assert/require in the contract has failed. Not everyone will understand what "reverted" means in this case.
|
Thanks, done. |
Jannis
approved these changes
Sep 2, 2019
|
Great! Thanks @leoyvens |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of graphprotocol/graph-node#1120.
First, the
callhost export may now returnnull, flagging a revert.SmartContract.callwill check for null and fail the subgraph with a helpful error message.SmartContract.tryCallis new and returns aCallResult, allowing the mapping to handle a revert. TheCallResultAPI changed a bit from the plan but does the same thing.