Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix triple quote comment syntax #3529

Merged
merged 1 commit into from
Feb 4, 2024
Merged

fix triple quote comment syntax #3529

merged 1 commit into from
Feb 4, 2024

Conversation

acao
Copy link
Member

@acao acao commented Feb 4, 2024

fixes #3515

i broke this by introducing support for double quote graphql strings, which are much less common that these important doc annotations

adds test cases to confirm this still works

Copy link

changeset-bot bot commented Feb 4, 2024

🦋 Changeset detected

Latest commit: e562c69

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
vscode-graphql-syntax Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@acao acao force-pushed the fix-triple-quote-comments branch from 633e71c to 0132940 Compare February 4, 2024 13:17

Verified

This commit was signed with the committer’s verified signature.
acao Rikki Schulte
@acao acao force-pushed the fix-triple-quote-comments branch from 0132940 to e562c69 Compare February 4, 2024 13:17
Copy link
Contributor

github-actions bot commented Feb 4, 2024

The latest changes of this PR are not available as canary, since there are no linked changesets for this PR.

@acao acao merged commit a38152e into main Feb 4, 2024
14 checks passed
@acao acao deleted the fix-triple-quote-comments branch February 4, 2024 13:58
@acao acao mentioned this pull request Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[vscode-graphql-syntax] (v1.2.3) triple double-quote comment syntax broken for TypeScript
1 participant