-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extend
incorrectly allows repeating of non-repeatable directives
#2442
Comments
IvanGoncharov
added a commit
to IvanGoncharov/graphql-js
that referenced
this issue
Feb 8, 2020
IvanGoncharov
added a commit
to IvanGoncharov/graphql-js
that referenced
this issue
Feb 8, 2020
IvanGoncharov
added a commit
to IvanGoncharov/graphql-js
that referenced
this issue
Feb 8, 2020
IvanGoncharov
added a commit
that referenced
this issue
Feb 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
While working on #2276, it was discovered that it was possible to extend a type of a non-repeatable directive multiple times. [comment].
Simple example that should NOT be allowed:
It's my understanding that
extend
should simply try to add the directive here to the previous list of directives, and that should only be allowed if the directive is either not present, or is repeatable.PR with failing test case: #2440
The text was updated successfully, but these errors were encountered: