[WIP] Add test case that repeats directive in extend #2440
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvanGoncharov
added a commit
to IvanGoncharov/graphql-js
that referenced
this pull request
Feb 8, 2020
IvanGoncharov
added a commit
to IvanGoncharov/graphql-js
that referenced
this pull request
Feb 8, 2020
IvanGoncharov
added a commit
to IvanGoncharov/graphql-js
that referenced
this pull request
Feb 8, 2020
IvanGoncharov
added a commit
that referenced
this pull request
Feb 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #2276, it was discovered that it was possible to extend a type of a non-repeatable directive multiple times. [comment].
At first glance, the
duplicate directives on SDL definitionstestcase appears to cover this situation, but actually is only throwing errors because the directive is repeated multiple times on the same location.As discussed in 2020-02-06's Working Group meeting, the consensus was that it should not be possible to extend directives that were already specified.
I believe these test cases should cover the various use-cases, but does not (yet) fix the problem. Help is welcome.