Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Babel 7 preparation: Switch babel config to JS #1348

Merged
merged 1 commit into from
Jun 1, 2018
Merged

Babel 7 preparation: Switch babel config to JS #1348

merged 1 commit into from
Jun 1, 2018

Conversation

IvanGoncharov
Copy link
Member

It's the first step towards Babel 7: #1266
Based on this article: https://fatfisz.com/blog/using-babelrc-js-today

IvanGoncharov
IvanGoncharov commented May 14, 2018
View reviewed changes
.babelrc
["transform-es2015-destructuring", {"loose": true}],
["transform-es2015-spread", {"loose": true}]
]
"presets": ["./.babelrc.js"]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will remove this file after switching to Babel7

@IvanGoncharov IvanGoncharov requested a review from mjmahone May 14, 2018 15:34
@IvanGoncharov IvanGoncharov mentioned this pull request May 22, 2018
Closed
@leebyron
Copy link
Contributor

want to resolve conflicts here?

@IvanGoncharov
Copy link
Member Author

@leebyron Done

@IvanGoncharov
Copy link
Member Author

@leebyron Already rebased + it blocks #1350. Can I merge it?

mjmahone
mjmahone approved these changes Jun 1, 2018
View reviewed changes
Copy link
Contributor

@mjmahone mjmahone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah we're going to pull the 14.0 trigger for the next release, so let's merge this so we can do the babel 7 upgrade.

@IvanGoncharov IvanGoncharov merged commit eb8ef7a into graphql:master Jun 1, 2018
@IvanGoncharov IvanGoncharov deleted the babelrcToJS branch June 1, 2018 08:10
@IvanGoncharov
Copy link
Member Author

@mjmahone Thanks for the review 👍 Merged 🎉

@snyk-bot snyk-bot mentioned this pull request Apr 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjmahone mjmahone mjmahone approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@IvanGoncharov @leebyron @mjmahone @facebook-github-bot