-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.13.3 #1346
0.13.3 #1346
Conversation
@mjmahone Not directly related to this PR. But I think we need to have a special label for all PR with breaking changes. I got this idea from mocha repo: |
Yeah I think that's a good idea, especially if it is enforced on PRs themselves: we wouldn't pull in PRs that have semver-major changes until just before we'd want a new major version released. :/ I unfortunately simultaneously really need to bump a version, don't want to break people currently on |
I think it's best possible solution in the current situation 👍 |
@mjmahone I don't think there are any critical PRs that should be merged before release, except for #1353 which fixes CI for |
Let's wait on this - we published that the next version would be v14 and we've merged some breaking changes. |
In fact - why not just update this to be a v14 bump instead |
0.13.0 -> 0.14.0 is semver equivalent - starting with 0. effectively treats the next number as a major breaking. I'm not sure it's necessary to release 0.14 instead of 14.0? Why bother with changing plans? |
Yeah I think we should move to 14.0 based on this discussion. Not sure though what is necessary to get there: were there other breaking changes we need to pull in? |
@mjmahone @leebyron I think people wanted So I think we should review all proposed breaking changes that we have at the moment and either reject or merge them. To minimize possible risks I think we need to make I also think it would be great if release notes for
|
No description provided.