createSourceEventStream: remove deprecated positional argument overload #3635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for compassionate-pike-271cb3 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
yaacovCR
added
the
PR: breaking change 💥
|
Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋 Supported commandsPlease post this commands in separate comments and only one per comment:
|
IvanGoncharov
previously requested changes
Jun 10, 2022
There was a problem hiding this comment.
@yaacovCR With exception of an issue with "positional test" it's ready to be merged.
yaacovCR
added a commit
to yaacovCR/graphql-js
that referenced
this pull request
Jun 12, 2022
yaacovCR
force-pushed
the
remove-deprecated
branch
from
7c212c0 to
3d49fda
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #3634, which introduced a named argument form for the exported function and deprecated the original positional argument overload. This is to be backported to v16.
This PR removes the deprecated format from v17. It is a BREAKING CHANGE and cannot be backported.
This PR depends on #3634.