build-npm/deno: use TS to find all *.ts files #3741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Remove custom code for finding *.ts files and reuse code from typescript library
|
Hi @IvanGoncharov, I'm @github-actions bot happy to help you with this PR 👋 Supported commandsPlease post this commands in separate comments and only one per comment:
|
✅ Deploy Preview for compassionate-pike-271cb3 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
cowboyd
added a commit
to thefrontside/graphgen
that referenced
this pull request
May 4, 2023
The [test were failing when updating the website][1] because we had to use some specifics of the way `https://esm.sh` bundled graphql-js by reaching into the `/graphql` directory of the npm package directly. However, now that [GraphQL-js officially supports Deno][2] we can upgrade it. This also resolves a dependency in the gaussian distribution library we used to pin it at a single version. [1]: https://github.com/thefrontside/graphgen/actions/runs/4876196677/jobs/8699372244 [2]: graphql/graphql-js#3741
cowboyd
added a commit
to thefrontside/graphgen
that referenced
this pull request
May 5, 2023
The [test were failing when updating the website][1] because we had to use some specifics of the way `https://esm.sh` bundled graphql-js by reaching into the `/graphql` directory of the npm package directly. However, now that [GraphQL-js officially supports Deno][2] we can upgrade it. This also resolves a dependency in the gaussian distribution library we used to pin it at a single version. [1]: https://github.com/thefrontside/graphgen/actions/runs/4876196677/jobs/8699372244 [2]: graphql/graphql-js#3741
cowboyd
added a commit
to thefrontside/graphgen
that referenced
this pull request
May 5, 2023
The [test were failing when updating the website][1] because we had to use some specifics of the way `https://esm.sh` bundled graphql-js by reaching into the `/graphql` directory of the npm package directly. However, now that [GraphQL-js officially supports Deno][2] we can upgrade it. This also resolves a dependency in the gaussian distribution library we used to pin it at a single version. [1]: https://github.com/thefrontside/graphgen/actions/runs/4876196677/jobs/8699372244 [2]: graphql/graphql-js#3741
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: Remove custom code for finding *.ts files and reuse code from typescript library