Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️Upgrade graphql and gaussian dependencies #63

Merged
merged 1 commit into from
May 5, 2023
Merged

⬆️Upgrade graphql and gaussian dependencies #63

merged 1 commit into from
May 5, 2023

Conversation

cowboyd
Copy link
Member

@cowboyd cowboyd commented May 4, 2023

Motivation

The test were failing when updating the website because we had to use some specifics of the way https://esm.sh bundled graphql-js by reaching into the /graphql directory of the npm package directly.

Approach

However, now that GraphQL-js officially supports Deno we can upgrade it. This also resolves a dependency in the gaussian distribution library we used to pin it at a single version.

@cowboyd cowboyd requested review from taras, dagda1, jbolda and wKich May 4, 2023 19:14
Copy link
Member

@taras taras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

The [test were failing when updating the website][1] because we had to
use some specifics of the way `https://esm.sh` bundled graphql-js by
reaching into the `/graphql` directory of the npm package directly.

However, now that [GraphQL-js officially supports Deno][2] we can
upgrade it. This also resolves a dependency in the gaussian
distribution library we used to pin it at a single version.

[1]: https://github.com/thefrontside/graphgen/actions/runs/4876196677/jobs/8699372244
[2]: graphql/graphql-js#3741
@cowboyd cowboyd merged commit b08795e into v1 May 5, 2023
@cowboyd cowboyd deleted the fix-deps branch May 5, 2023 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants