Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert from docusaurus to nextra #4240

Merged
merged 3 commits into from
Oct 20, 2024
Merged

Convert from docusaurus to nextra #4240

merged 3 commits into from
Oct 20, 2024

Conversation

JoviDeCroock
Copy link
Member

@JoviDeCroock JoviDeCroock commented Oct 15, 2024

This converts the existing docusaurus website to nextra just like https://github.com/graphql/graphql.github.io. This is a first step in moving the documentation here and having a redirect from graphql.org to graphql-js.org.

Not sure yet why codecov started failing 😅 when I run testonly:cover locally it tells me we are 100% covered.

WDYT about isolating the dependencies for the website in that folder? As seen in 9c7d615 this prevents the weird CI leaks that we're seeing

Resolves #4200

@JoviDeCroock JoviDeCroock requested a review from a team as a code owner October 15, 2024 18:14
Copy link

Hi @JoviDeCroock, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

@JoviDeCroock JoviDeCroock force-pushed the nextra-conversion branch 5 times, most recently from c32daa0 to cc1aed1 Compare October 16, 2024 06:02
@JoviDeCroock JoviDeCroock force-pushed the nextra-conversion branch 6 times, most recently from f952870 to ee4e1df Compare October 16, 2024 08:35
@yaacovCR
Copy link
Contributor

WDYT about isolating the dependencies for the website in that folder? As seen in 9c7d615 this prevents the weird CI leaks that we're seeing

Sounds fine, ideally, we wouldn’t need to do that but we can always try to fix it later

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@yaacovCR
Copy link
Contributor

  1. I get the following error when running npm run build locally, not sure if it is an error on my side. npm run dev works.

image

  1. Just a note that this PR does not (yet) have the extra context at https://graphql-js.org missing at https://graphql.org/graphql-js => add additional content from graphql-js repository graphql.github.io#1782 => presumably that is for a later PR

  2. Existing graphql-js.org version of website has a typedoc view of the API (https://graphql-js.org/api/) => just noting that to open up discussion for whether we will be doing something similar

@JoviDeCroock
Copy link
Member Author

@yaacovCR I think I found what could have been causing the issue for you 😅 I purposefully didn't add the new content yet to make the PR easier to review, currently it's basically a copy of the content within graphql.org and moving the website to its own lockfile. Regarding typedoc, I am personally not a big fan as TypeScript provides more value here.

package.json Outdated Show resolved Hide resolved
@JoviDeCroock JoviDeCroock force-pushed the nextra-conversion branch 4 times, most recently from 7bc980b to 31e2ed2 Compare October 18, 2024 08:01
website/package.json Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
@JoviDeCroock JoviDeCroock force-pushed the nextra-conversion branch 2 times, most recently from 2c2117b to a120b3f Compare October 18, 2024 14:04
Co-authored-by: Yaacov Rydzinski  <yaacovCR@gmail.com>
Copy link

vercel bot commented Oct 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
graphql-js ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 19, 2024 6:22pm

@JoviDeCroock JoviDeCroock merged commit d1c9c42 into 16.x.x Oct 20, 2024
31 checks passed
@yaacovCR yaacovCR deleted the nextra-conversion branch October 20, 2024 09:30
yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request Nov 26, 2024
This converts the existing docusaurus website to nextra just like
https://github.com/graphql/graphql.github.io. This is a first step in
moving the documentation here and having a redirect from graphql.org to
graphql-js.org.

Not sure yet why codecov started failing 😅 when I run `testonly:cover`
locally it tells me we are 100% covered.

WDYT about isolating the dependencies for the website in that folder? As
seen in
graphql@9c7d615
this prevents the weird CI leaks that we're seeing

Resolves graphql#4200

---------

Co-authored-by: Yaacov Rydzinski <yaacovCR@gmail.com>
yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request Dec 3, 2024
This converts the existing website to nextra just like
https://github.com/graphql/graphql.github.io. This is a first step in
moving the documentation here and having a redirect from graphql.org to
graphql-js.org.

Not sure yet why codecov started failing 😅 when I run `testonly:cover`
locally it tells me we are 100% covered.

WDYT about isolating the dependencies for the website in that folder? As
seen in
graphql@9c7d615
this prevents the weird CI leaks that we're seeing

Resolves graphql#4200

---------

Co-authored-by: Yaacov Rydzinski <yaacovCR@gmail.com>
yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request Dec 3, 2024
This converts the existing website to nextra just like
https://github.com/graphql/graphql.github.io. This is a first step in
moving the documentation here and having a redirect from graphql.org to
graphql-js.org.

Not sure yet why codecov started failing 😅 when I run `testonly:cover`
locally it tells me we are 100% covered.

WDYT about isolating the dependencies for the website in that folder? As
seen in
graphql@9c7d615
this prevents the weird CI leaks that we're seeing

Resolves graphql#4200

---------

Co-authored-by: Yaacov Rydzinski <yaacovCR@gmail.com>
yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request Dec 3, 2024
This converts the existing website to nextra just like
https://github.com/graphql/graphql.github.io. This is a first step in
moving the documentation here and having a redirect from graphql.org to
graphql-js.org.

Not sure yet why codecov started failing 😅 when I run `testonly:cover`
locally it tells me we are 100% covered.

WDYT about isolating the dependencies for the website in that folder? As
seen in
graphql@9c7d615
this prevents the weird CI leaks that we're seeing

Resolves graphql#4200

---------

Co-authored-by: Yaacov Rydzinski <yaacovCR@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

graphql-js.org is only partially deprecated
3 participants