add additional content from graphql-js repository #1782
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yaacovCR is attempting to deploy a commit to the The GraphQL Foundation Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
JoviDeCroock
approved these changes
Oct 15, 2024
|
I thought we were planning to go the other way? |
|
We are yes, I can't close/... here 😅 graphql/graphql-js#4240 |
|
I can close as author, closing in favor of graphql/graphql-js#4240 |
JoviDeCroock
added a commit
to graphql/graphql-js
that referenced
this pull request
Oct 20, 2024
JoviDeCroock
added a commit
to graphql/graphql-js
that referenced
this pull request
Oct 20, 2024
JoviDeCroock
added a commit
to graphql/graphql-js
that referenced
this pull request
Oct 20, 2024
JoviDeCroock
added a commit
to graphql/graphql-js
that referenced
this pull request
Oct 20, 2024
yaacovCR
pushed a commit
to yaacovCR/graphql-js
that referenced
this pull request
Nov 26, 2024
yaacovCR
pushed a commit
to yaacovCR/graphql-js
that referenced
this pull request
Dec 3, 2024
yaacovCR
pushed a commit
to yaacovCR/graphql-js
that referenced
this pull request
Dec 3, 2024
yaacovCR
pushed a commit
to yaacovCR/graphql-js
that referenced
this pull request
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like graphql-js.org has been deprecated in favor of graphql.org/graphql-js. The README at graphql-js even points to graphql.org/graphql-js.
So we really should:
I am not in a position to do 2, but this PR can do 1, and once 2 is done, I can do 3.